Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement manga and some anime endpoints. #9

Merged
merged 27 commits into from
Nov 25, 2024
Merged

Conversation

r3tr0ananas
Copy link
Collaborator

@r3tr0ananas r3tr0ananas commented Nov 24, 2024

Added things

  • anime

    • getAnimeNews
    • getAnimeForum
    • getAnimeMoreInfo
    • getAnimeRecommendations
    • getAnimePictures
    • getAnimeReviews
    • getAnimeRelations
    • getAnimeExternal
  • genres

    • getAnimeGenres
    • getMangaGenres
  • manga

    • getMangaFullById
    • getMangaById
    • getMangaCharacters
    • getMangaNews
    • getMangaTopics
    • getMangaPictures
    • getMangaStatistics
    • getMangaMoreInfo
    • getMangaRecommendations
    • getMangaUserUpdates
    • getMangaReviews
    • getMangaRelations
    • getMangaExternal
    • getMangaSearch
  • random

    • getRandomAnime
    • getRandomManga
    • getRandomCharacters

@THEGOLDENPRO
Copy link
Owner

if there's any data models that can be reused in the anime side of things feel free to make a separate object for it like what I did with Title() and Name() in the /helpers directory.

@r3tr0ananas
Copy link
Collaborator Author

I did

@THEGOLDENPRO
Copy link
Owner

the cookery is fucking crazy

@THEGOLDENPRO THEGOLDENPRO marked this pull request as draft November 24, 2024 18:32
@r3tr0ananas r3tr0ananas marked this pull request as ready for review November 25, 2024 10:52
@r3tr0ananas
Copy link
Collaborator Author

r3tr0ananas commented Nov 25, 2024

I removed some endpoints because I’m going to go crazy if I have to do more deserialization.

@THEGOLDENPRO
Copy link
Owner

rip

image

@THEGOLDENPRO
Copy link
Owner

are these tests running in the same environment or something, I've never hit a rate limit error with the unit tests on my machine

@THEGOLDENPRO
Copy link
Owner

I added JikanIterableResource so you no longer have to repeat __next__ and __iter__ implementations. You still need to define those functions though and call super() or else we'll get zero type annotation and I don't know of any other way to fix that currently other than implementing them.

def __next__(self) -> AnimeCharacter:
return super().__next__()
def __iter__(self) -> Generator[AnimeCharacter, Any, None]:
return super().__iter__()

@r3tr0ananas
Copy link
Collaborator Author

are these tests running in the same environment or something, I've never hit a rate limit error with the unit tests on my machine

probably

@r3tr0ananas
Copy link
Collaborator Author

Should I change everything to JikanIterableResource for all resources that use iteration or will you do it?

@THEGOLDENPRO THEGOLDENPRO changed the title feat: manga and some other stuff. feat: implement manga and some anime endpoints. Nov 25, 2024
@THEGOLDENPRO
Copy link
Owner

Should I change everything to JikanIterableResource for all resources that use iteration or will you do it?

feel free to do them, I don't have anything to commit rn

@THEGOLDENPRO
Copy link
Owner

Are you happy to merge this?

@THEGOLDENPRO
Copy link
Owner

oh yeah we need to link all of this to the docs

@r3tr0ananas
Copy link
Collaborator Author

We can merge this if you want

@THEGOLDENPRO
Copy link
Owner

Alright I'm merging this and setting the documentation stuff as a seperate github issue

@THEGOLDENPRO THEGOLDENPRO merged commit 0b2ec5f into main Nov 25, 2024
7 checks passed
@THEGOLDENPRO THEGOLDENPRO deleted the feat/manga branch November 25, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants